Following on from
my comments on Scala, -what about
Apache Groovy?
It's been a great language for writing tests in, especially when you turn on static compilation, but there are some gotchas.
- It's easy to learn if you know Java, so the effort of adding it to a project is straightforward.
- It's got that auto
log.info("timer is at $timer") string expansion. But the rules of when they get expanded are 'complex'.
- Lists and Maps are in the language. This makes building up structures for testing trivially easy.
- The maven groovy task is a nice compiler for java and groovy
- Groovydoc is at least 10x faster than javadoc. It makes you realise that javadoc hasn't had any engineering care for decades; right up there with
rmic.
- Its closeness to Java makes it easy to learn, and you can pretty much paste Java code into groovy and have it work.
- The groovy
assert statement is best in class. If it fails, it deconstructs the expression, listing the toString() value of every parameter. Provided you provide meaningful string values, debugging a failed expression is way easier than anything else.
- Responsive dev team. One morning some maven-always-updates artifact was broken, so a stack trace followed the transition of countries into the next day. We in Europe hit it early and filed bugs -it was fixed before CA noticed. Try that with javac-related bugs and you probably won't have got as far as working out how to set up an Oracle account for bug reporting before the sun sets and the video-conf hours begin.
As I said, I think it's great for testing. Here's some test of mine
@CompileStatic // we want this compiled in advance to find problems early
@Slf4j // and inject a 'log' field for logging
class TestCommonArgParsing implements SliderActions, Arguments {
...
@Test
public void testList1Clustername() throws Throwable {
// note use of [ list ]
ClientArgs ca = createClientArgs([ACTION_LIST, 'cluster1'])
assert ca.clusterName == 'cluster1'
assert ca.coreAction instanceof ActionListArgs
}
...
}
What don't I like?
- Different scoping rules: everything defaults to public. Which you have to remember when switching languages
- Line continuation rules need to be tracked too ... you need the end of the line to be unfinished (e.g trail the '+' sign in a string concatenation). Scala makes a better job of this.
- Sometimes IDEA doesn't pick up use of methods and fields in your groovy source, so the refactorings may omit bits of your code.
- Sometimes that
@CompileStatic tag results in compilation errors, normally fixed by commenting out that attribute. Implication: the static and dynamic compiler are 'different'
- Using
== for .equals() is again, danger.
- The notion of truthyness in comparisons is very C/C++-ish: you need to know the rules. All null values are false, as are integer values that are zero And strings which are empty. Safe strategy: just be explicit.
- It's not so much type inference as type erasure, with runtime stacks as the consequence.
- The logic about when strings are expanded can sometimes be confusing.
- You can't paste from groovy to java without major engineering work. At least you can —more than you could pasting from Scala to Java— but it makes converting test code to production harder.
Here's an example of something I like. This is possible in Scala, Java 8 will make viable-ish too. It's a test which issues a REST call to get the current slider app state, pushes out new value and then spins awaiting a remote state change, passing in a method as the probe parameter.
public void testFlexOperation() {
// get current state
def current = appAPI.getDesiredResources()
// create a guaranteed unique field
def uuid = UUID.randomUUID()
def field = "yarn.test.flex.uuid"
current.set(field, uuid)
appAPI.putDesiredResources(current.confTree)
repeatUntilSuccess("probe for resource PUT",
this.&probeForResolveConfValues,
5000, 200,
[
"key": field,
"val": uuid
],
true,
"Flex resources failed to propagate") {
def resolved = appAPI.getResolvedResources()
fail("Did not find field $field=$uuid in\n$resolved")
}
}
Outcome probeForResolveConfValues(Map args) {
String key = args["key"]
String val = args["val"]
def resolved = appAPI.getResolvedResources()
return Outcome.fromBool(resolved.get(key) == val)
}
That
Outcome class has three values:
Success,
Retry and
Fail; the probe returns an
Outcome and the executor,
repeatUntilSuccess execs the probe closure until the Duration of retries exceeds the timeout, the probe succeeds, or a
Fail response triggers a fail fast. It allows my tests to iterate until success, but if that probe can detect an unrecoverable failure —bail out fast. It's effective at avoiding long
sleep() calls, which introduce needless delays to fast systems, and which are incredibly brittle in slow ones.
If you look at a lot of Hadoop test failures, they're of the form "test timeout on Jenkins", with a fix of "increase sleep times". Closure-based probes, with probes that detect unrecoverable failures (e.g. network unreachable is a hard failure, different from 404, which may go away on retries). Anyway: closures are great in tests. Not just for probes, but for functions to call once a system is in a desired state (e.g. web server launched).
We use Groovy in Slider for testing; the extra productivity and those assert statements are great. So does Bigtop —indeed, we use some Bigtop code as the basis for our functional tests. But would I advocate it elsewhere? I don't know. It's close enough to Java to co-exist, whereas I wouldn't advocate using Scala, Clojure or similar purely for testing Java code
*within the same codebase*.
There's also Java 8 to consider. It is a richer language, gives us those closures, just not the maps or the lists. Or the assertions. Or the inline string expansion. But...it's very close to production code, even if that production code is java-7 only -and you can make a very strong case for learning Java 8. Accordingly,
- I'm happy to continue with Groovy in Slider tests.
- For an app where the production code was all Java, I wouldn't advocate adopting groovy now: Java 8 offers enough benefits to be the way forward.
- If anyone wants to add java-8 closure-based tests in Hadoop trunk, I'd be supportive there too.
